Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optimized #fid_collections_by_type query for Wings #4432

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

no-reply
Copy link
Contributor

this is follow-up to #4430, adding an optimized query to Wings. this should be vastly faster than the default query for the Wings adapter.

@samvera/hyrax-code-reviewers

cjcolvar
cjcolvar previously approved these changes Jul 13, 2020
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me. I just had one non-blocking question.

this is follow-up to #4430, adding an optimized query to Wings. this should be
vastly faster than the default query for the Wings adapter.
@no-reply
Copy link
Contributor Author

i fixed the failing test.

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@no-reply no-reply merged commit 6ca123e into master Jul 13, 2020
@no-reply no-reply deleted the wings-col-type branch July 13, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants